Fixes outside dates movement while hovering #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on hovering outside dates
|
@ljharb Hi, I would really appreciate if you can review this. |
majapw
approved these changes
May 29, 2018
There was a problem hiding this comment.
This seems reasonable to me, assuming @mukuljainx has played with this in storybook and verified that it makes sense. :)
|
@majapw yes, I did. Thanks 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is with reference to #1172 and #308
In DayPicker.jsx
at line number 201,
CalendarDay__outsidehave default border 0 but we have some border on hovering andCalendarDay__outsidehave no different style for hover, which moves the date on hovering.I added property
border: 0on hover forCalendarDay__outsidesolving the issue.