Add focusable="false" to dls-web svgs #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because SVGs are focusable by default in IE, we need to add this attribute to prevent this behavior and specifically to prevent a double-focus on our interactive buttons.
majapw
added
semver-patch: fixes/refactors/etc
backwardok
approved these changes
May 29, 2018
ljharb
approved these changes
May 29, 2018
|
@ljharb Yes! Sorry I meant to say that in the description. I just ran them through svgo. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because SVGs are focusable by default in IE, we need to add this attribute to prevent this behavior
and specifically to prevent a double-focus by screen-readers on our interactive buttons (e.g. month navigation).
to: @backwardok @erin-doyle