Deprecate internal OutsideClickHandler in favor of react-outside-click-handler package #1191
Conversation
majapw
added
the
semver-patch: fixes/refactors/etc
majapw
force-pushed
the
maja-deprecate-outside-click-handler-in-favor-of-npm-package
branch
from
f5a01a3
to
9ac1bdd
Compare
|
|
||
| // import { forbidExtraProps } from 'airbnb-prop-types'; // TODO: add to propTypes; semver-major | ||
| import { addEventListener } from 'consolidated-events'; | ||
| console.log(` |
There was a problem hiding this comment.
this should use console.warn instead, i think
majapw
force-pushed
the
maja-deprecate-outside-click-handler-in-favor-of-npm-package
branch
2 times, most recently
from
195703c
to
f4df2a8
Compare
…k-handler package
majapw
force-pushed
the
maja-deprecate-outside-click-handler-in-favor-of-npm-package
branch
from
f4df2a8
to
5751221
Compare
|
So for some reason the status check is stuck even though the job ran successfully on Travis - https://travis-ci.org/airbnb/react-dates/builds/385911685 @ljharb is this safe to merge or is something broken? |
|
Refresh the page? Everything looks fine except that the coverage threshold still needs tweaking |
|
@ljharb when I click the travis link in coveralls (which what causes the pass or fail i thought), the travis job is green. Previously it told me that the branch coverage needed tweaking. Is it because of the missed lines in the diff?
Incidentally this missed line is the console.warn in the OutsideClickHandler... so if that's the case, I'm inclined to just merge through. |
|
I think it's fine to merge through as long as it's not going to start failing on successive PRs. |
majapw
deleted the
maja-deprecate-outside-click-handler-in-favor-of-npm-package
branch
This is a patch because I don't actually delete the OutsideClickHandler in this change but rather ship it with a deprecation message.
to: @ljharb