Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inputRef.blur() call that was causing a focus trap in Safari/IE #1214

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Jun 15, 2018

Fix for #937

This code was originally added in #212, but weirdly I cannot reproduce the underlying issue. There have been a lot of changes to the internal structure of react-dates... but it is still surprising. :/

to: @backwardok @ljharb @wonnage

@majapw majapw added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Jun 15, 2018
@coveralls
Copy link

coveralls commented Jun 15, 2018

Coverage Status

Coverage decreased (-0.009%) to 85.17% when pulling 8416bc9 on maja-fix-keyboard-trap-input-issue into 0c7d9af on master.

Copy link
Contributor

@backwardok backwardok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good. ionno what's up with all the builds :P

@ljharb
Copy link
Member

ljharb commented Jun 15, 2018

my bad; babel-preset-airbnb v2.5.0 is broken; v2.5.1 fixes it.

@ljharb
Copy link
Member

ljharb commented Jun 15, 2018

These failures look legit, fwiw.

@majapw majapw force-pushed the maja-fix-keyboard-trap-input-issue branch from 80cdfdd to 8416bc9 Compare June 18, 2018 18:10
@majapw majapw merged commit 4c641de into master Jun 18, 2018
@majapw majapw deleted the maja-fix-keyboard-trap-input-issue branch June 18, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants