Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename renderMonth to renderMonthTitle and renderCaption to renderMonthElement #1220

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Rename renderMonth to renderMonthTitle and renderCaption to renderMonthElement #1220

merged 1 commit into from
Jun 21, 2018

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Jun 19, 2018

Does this make sense?

@GoGoCarl @ljharb @backwardok

@backwardok suggested renderMonthText and renderMonthHTML but I don't know that that's very inline with other props in react-dates. title matches the current nomenclature? renderTitleElement might be clearer? Idk.

I wanted to get this out with the latest breaking version.

@majapw majapw added the semver-major: breaking change A non-backwards-compatible change; anything that breaks code - including adding a peerDep. label Jun 19, 2018
@coveralls
Copy link

coveralls commented Jun 19, 2018 •
edited

Coverage Status

Coverage remained the same at 84.785% when pulling 6a5d8ee on maja-clean-up-caption-month-naming into ca3906b on master.

@GoGoCarl
Copy link
Contributor

@majapw FWIW I actually like the combination of renderMonthText and renderMonthElement, or even renderTitleText/renderTitleElement, as the method names associate the two together as related, with the suffix giving sufficient context of what's expected to be returned (I'd prefer "Element" over "HTML").

ljharb
ljharb reviewed Jun 19, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion, I think renderMonthText and renderMonthElement work great, and should be mutually exclusive

@majapw majapw force-pushed the maja-clean-up-caption-month-naming branch from 1d1f4d8 to 4710d99 Compare June 20, 2018 00:02
@majapw majapw force-pushed the maja-clean-up-caption-month-naming branch from 4710d99 to 6a5d8ee Compare June 20, 2018 23:32
@majapw majapw merged commit 2081bd8 into master Jun 21, 2018
@majapw majapw deleted the maja-clean-up-caption-month-naming branch June 21, 2018 16:40
@picosam picosam mentioned this pull request Jun 22, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@backwardok backwardok backwardok approved these changes

Assignees
No one assigned
Labels
semver-major: breaking change A non-backwards-compatible change; anything that breaks code - including adding a peerDep.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@majapw @coveralls @GoGoCarl @ljharb @backwardok