Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass through modifiers propType #1231

Merged
merged 3 commits into from
Jul 3, 2018
Merged

Pass through modifiers propType #1231

merged 3 commits into from
Jul 3, 2018

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jun 24, 2018

This is related to #1198.

An alternative approach (which I'm happy to change to) would put the modifiers Set shape in a separate tiny file, and import it where needed.

@ljharb ljharb added the semver-minor: new stuff Any feature or API addition. label Jun 24, 2018
@ljharb ljharb requested a review from majapw June 24, 2018 22:33
@coveralls
Copy link

coveralls commented Jun 24, 2018 •
edited

Coverage Status

Coverage increased (+0.05%) to 84.637% when pulling 3eb2170 on modifiers_proptypes into 83ec316 on master.

majapw
majapw approved these changes Jun 29, 2018
View reviewed changes
Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljharb this doesn't actually fully address the issue, but rather is designed to help us catch it earlier?

I slightly prefer a separate file.

@ljharb
Copy link
Member Author

ljharb commented Jun 29, 2018

@majapw yes, exactly right. Separate file it is!

@ljharb
Copy link
Member Author

ljharb commented Jun 29, 2018

k updated, PTAL - i also made the propType stricter.

@ljharb ljharb force-pushed the modifiers_proptypes branch 4 times, most recently from a889cf5 to 8f1ac91 Compare June 30, 2018 20:00
majapw
majapw approved these changes Jul 3, 2018
View reviewed changes
Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

god custom prop definitions are always barely readable. Thank goodness for the display name. :)

@ljharb ljharb merged commit 1d2aa33 into master Jul 3, 2018
@ljharb ljharb deleted the modifiers_proptypes branch July 3, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majapw majapw majapw approved these changes

Assignees
No one assigned
Labels
semver-minor: new stuff Any feature or API addition.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ljharb @coveralls @majapw