Add date offset functionality to DateRangePicker #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge please 馃檹 |
ljharb
previously requested changes
Aug 23, 2018
ljharb
added
semver-minor: new stuff
jakeclements
force-pushed
the
date-offset-in-DateRangePicker
branch
3 times, most recently
from
bb42bfa
to
ca84fb0
Compare
|
Thanks for the review @ljharb, I've updated this PR to align with master and actioned your requests. If you see anything else you think needs an update please let me know. |
ljharb
removed
the
needs rebase
|
Is this still up? i have same problem/request #1062 |
|
Hey @majapw, there seems to be some interest in this. If you're able to review the changes I'm happy to continue supporting this to get it merged. |
majapw
approved these changes
Feb 1, 2019
| @@ -483,6 +483,10 @@ export default class DayPickerRangeController extends BaseClass { | |||
| startDate = getSelectedDateOffset(startDateOffset, day); | |||
| endDate = getSelectedDateOffset(endDateOffset, day); | |||
|
|
|||
| if (this.isBlocked(startDate) || this.isBlocked(endDate)) { | |||
There was a problem hiding this comment.
Was this behavior broken before?
There was a problem hiding this comment.
It was, I noticed it in making these updates.
|
Happy to merge it after the conflict is resolved @jakeclements Man, this really dropped off my radar. Super sorry! :) Would have merged earlier if I had realized it was such a quick change. 馃檴 |
jakeclements
force-pushed
the
date-offset-in-DateRangePicker
branch
from
ca84fb0
to
2355698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #1062, this PR passes date offset functionality up to the DateRangePicker.
Tests for date offsets are already included within the DayPickerRangeController spec.
If tests are required for the additional functionality this adds to the DateRangePicker please point me to the spec and I'll add them, an appropriate file to add these wasn't clear to me. 馃槄
I'm happy to discuss the inclusion of this PR.