fix for vertical scrollable modifiers #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add regression tests for modifier if vertically scrollable load more months
ljharb
added
the
semver-patch: fixes/refactors/etc
ljharb
force-pushed
the
amh-fix-vertical-scrollable-modifiers
branch
from
4174bd2
to
5c1322c
Compare
|
I've rebased this on top of #1261; so merging this one can close both. |
majapw
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of months was incorrectly assumed to be constant in
addModifierfor theVERTICAL_SCROLLABLEorientation. I switched it to use the number of months invisibleDays. I was going to switch it for all orientations, but then decided this would be less error prone (smaller change).@majapw