Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing border-styles to minimize border overlapping #1328

Merged
merged 2 commits into from
Sep 5, 2018
Merged

Changing border-styles to minimize border overlapping #1328

merged 2 commits into from
Sep 5, 2018

Conversation

ysdexlic
Copy link
Contributor

Fixing some funky issues with the border-style, here's a before/after screenshot explaining the differences

Before (Live)

  • Border of the hovered day overlaps border of the selected range (making the date box look taller)
  • Top border of bottom left 3 selected in range does not have the selected color
  • Top border of the second day in range is incorrect (making it look a pixel shorter than the first day)
  • Last day has a border to the left (making it a pixel thinner than the first day)
    screen shot 2018-08-28 at 19 58 54

After

  • All days in range have the correct border color
  • Hovered day now does not overlap the selection
  • Last day now takes full width
    screen shot 2018-08-28 at 19 59 26

@coveralls
Copy link

coveralls commented Aug 28, 2018 •
edited

Coverage Status

Coverage remained the same at 84.875% when pulling b31a50c on ysdexlic:border-overlap-fix into 5442054 on airbnb:master.

@ljharb ljharb changed the title Changing border-styles to minimise border overlapping Changing border-styles to minimize border overlapping Aug 28, 2018
@ljharb ljharb requested a review from majapw August 28, 2018 19:24
majapw
majapw approved these changes Sep 4, 2018
View reviewed changes
Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Rebased and added the styles for the CCD as well

@majapw majapw merged commit ee92846 into react-dates:master Sep 5, 2018
@krissalvador27 krissalvador27 mentioned this pull request Feb 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majapw majapw majapw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ysdexlic @coveralls @majapw