Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only blur the activeElement after the month transition if available. #1345

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Sep 5, 2018

Fixes #1097

In IE11 and some other browsers, SVGs cannot be blurred. Notably, when you press the month nav, the SVG is sometimes focused. This causes a JS error in those browsers.

to: @ljharb @noratarano

@majapw majapw added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Sep 5, 2018
Copy link
Contributor

@noratarano noratarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.875% when pulling dcf8f8d on maja-patch-activeElement-blur-in-IE into ee92846 on master.

@majapw majapw merged commit 2b21fd7 into master Sep 5, 2018
@majapw majapw deleted the maja-patch-activeElement-blur-in-IE branch September 5, 2018 23:29
@calinoracation
Copy link

Thanks for making this change!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants