Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SingleDatePickerInputController component #1360

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Sep 14, 2018

This is the first step to creating a component structure that will allow consumers to asynchronously load the picker.

Basically, this creates an input controller component similar to the DateRangePickerInputController that takes care of everything related to input and input validation. There should be no functional change to any of the main components.

to: @ljharb @lencioni @noratarano

@majapw majapw added the semver-minor: new stuff Any feature or API addition. label Sep 14, 2018
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

src/components/SingleDatePicker.jsx Show resolved Hide resolved
src/components/SingleDatePicker.jsx Show resolved Hide resolved
src/components/SingleDatePickerInput.jsx Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 84.915% when pulling e376d2f on maja-add-SingleDatePickerInputController into 90c7506 on master.

@majapw majapw merged commit d857a24 into master Sep 14, 2018
@ljharb ljharb deleted the maja-add-SingleDatePickerInputController branch September 14, 2018 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor: new stuff Any feature or API addition.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants