Pass isOutsideRange prop to input controller
#1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Sep 21, 2018
|
@ljharb Updated with test. Thanks for reviewing! |
majapw
approved these changes
Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
SingleDatePickercomponent isn't passing theisOutsideRangeprop down to theSingleDatePickerInputControllersoSingleDatePickerInputControllerends up using the default range. This results in valid dates outside in the past to not get recognized by the calendar. By passing the prop down we can allow for dates in the past. You can see the behavior by entering in a date in the past in the Storybook example (notice it doesn't highlight the past-date - it does work for days in the future).Before
After