Fix incorrect VO for selected check-in date #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@majapw Can you take a look at this? Thanks! |
majapw
requested changes
Nov 6, 2018
src/utils/getCalendarDaySettings.js
Outdated
| if (modifiers.has(BLOCKED_MODIFIER)) { | ||
| if (modifiers.has(BLOCKED_MODIFIER) && selected) { | ||
| ariaLabel = getPhrase(dateIsSelected, formattedDate); | ||
| } else if (modifiers.has(BLOCKED_MODIFIER)) { | ||
| ariaLabel = getPhrase(dateIsUnavailable, formattedDate); | ||
| } else if (selected) { |
There was a problem hiding this comment.
would it make sense to just move the if(selected) condition to be fire? e.g.
if (selected) {
ariaLabel = getPhrase(dateIsSelected, formattedDate);
} else if (modifiers.has(BLOCKED_MODIFIER)) {
ariaLabel = getPhrase(dateIsUnavailable, formattedDate);
} else ...
nkinser
force-pushed
the
nk-fix-incorrect-VO-for-selected-checkin-date
branch
from
f362968
to
b0e86b7
Compare
|
@majapw PTAL! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an accessibility bug where VO incorrectly defines a selected check-in date in calendar as unavailable. This is fixed by checking if the day is both blocked and selected, and if this is true the phrase should be
dateIsSelected.