[RTL] Fix the SDP and DRP noflip util function #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In react-dates#1482 we added compatibility with react-with-direction. In the process we created a helper utility `noflip` to make it so that react-with-direction wouldn't interfere with the preexisting `isRTL` flag. This PR fixes the noflip behavior for Numbers, and adds unit tests.
majapw
approved these changes
Dec 12, 2018
| @@ -4,7 +4,7 @@ const NOFLIP = '/* @noflip */'; | |||
| // flipped in RTL contexts. This should be used only in situations where the style must remain | |||
| // unflipped regardless of direction context. See: https://github.com/kentcdodds/rtl-css-js#usage | |||
| export default function noflip(value) { | |||
| if (typeof value === 'number') return `${value}px`; | |||
| if (typeof value === 'number') return `${value}px ${NOFLIP}`; | |||
ljharb
added
the
semver-patch: fixes/refactors/etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #1482 we added compatibility with react-with-direction. In the process we
created a helper utility
noflipto make it so that react-with-directionwouldn't interfere with the preexisting
isRTLflag. This PR fixes the noflipbehavior for Numbers, and adds unit tests.
to: @majapw @ljharb @airbnb/ui-frameworks
Screenshot
example: DateRangePicker: with DirectionProvider
before
after
