Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-disabled prop to CalendarDay and CustomizableCalendarDay #1521

Merged

Conversation

nkinser
Copy link
Contributor

@nkinser nkinser commented Jan 30, 2019

This PR adds the prop aria-disabled to CalendarDay and CustomizableCalendarDay so that days that are unavailable have the "dimmed" label. The unavailable dates are still perceivable by VO.

Reviewers

@majapw @ljharb @backwardok

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.968% when pulling 5789ad9 on nkinser:nk--add-aria-disabled-to-calendar-day into e8b71d2 on airbnb:master.

Copy link
Contributor

@backwardok backwardok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from the a11y side! Not as familiar with the react-dates side so I'll let someone else stamp

@nkinser
Copy link
Contributor Author

nkinser commented Feb 4, 2019

@majapw can I please get a stamp? Thanks!

@ljharb ljharb requested a review from majapw February 4, 2019 20:03
@majapw majapw merged commit 277bed3 into react-dates:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants