Move the call to onDatesChange before the call to onFocusChange #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@majapw PTAL! |
|
If the ordering is important, then I think we should add a test that asserts it (also, you'll need to rebase) |
nkinser
force-pushed
the
nk--couple-dates-change-with-focus-change
branch
from
da543b2
to
957c028
Compare
ljharb
reviewed
Feb 5, 2019
ljharb
reviewed
Feb 5, 2019
nkinser
force-pushed
the
nk--couple-dates-change-with-focus-change
branch
from
50e2e7d
to
95ee636
Compare
ljharb
approved these changes
Feb 6, 2019
| wrapper.instance().onDayClick(clickDate); | ||
| expect(focusedInput).to.equal(END_DATE); |
There was a problem hiding this comment.
this does seem like a possible breaking change to me. @majapw?
There was a problem hiding this comment.
Yep! I'm gonna release it as v19 after I release the previous changes in a minor.
ljharb
added
the
semver-major: breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the call to
onDatesChangebeforeonFocusChange. The purpose of this change is to allow the logic ofonDatesChangeto potentially affect the logic ofonFocusChange.For example, I would like to allow users to click on certain unavailable dates and then show them a corresponding error state. When such a date is clicked, I do not want the focus to change because the date they clicked would not actually be selected. The logic of whether or not to change focus needs to occur in
onDatesChange, so this function needs to be called beforeonFocusChange.