Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing onKeyDown function to CalendarDay #901

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Add missing onKeyDown function to CalendarDay #901

merged 1 commit into from
Dec 13, 2017

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Dec 13, 2017

Eep.

Fixes #899

@ljharb

@majapw majapw added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Dec 13, 2017
ljharb
ljharb approved these changes Dec 13, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow this up with a regression test.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 85.487% when pulling 4d3b312 on maja-fix-on-key-down-error into 94e1852 on master.

@majapw majapw merged commit e3773ba into master Dec 13, 2017
@majapw majapw deleted the maja-fix-on-key-down-error branch December 13, 2017 20:56
@majapw majapw restored the maja-fix-on-key-down-error branch February 2, 2018 23:40
@erin-doyle erin-doyle deleted the maja-fix-on-key-down-error branch March 26, 2020 17:42
@ljharb ljharb restored the maja-fix-on-key-down-error branch March 26, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@majapw @coveralls @ljharb