Reopen https://github.com/airbnb/react-dates/pull/943 #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
added
the
semver-patch: fixes/refactors/etc
ljharb
previously approved these changes
Jan 16, 2018
test/components/DateInput_spec.jsx
Outdated
| const wrapper = shallow(<DateInput id="date" />).dive(); | ||
| wrapper.setState({ dateString }); | ||
| wrapper.instance().componentWillReceiveProps({ displayValue: '1991-07-13' }); | ||
| expect(wrapper.state().dateString).to.equal(''); |
There was a problem hiding this comment.
expect(wrapper.state()).to.have.property('dateString', '') has a better failure message
test/components/DateInput_spec.jsx
Outdated
| const wrapper = shallow(<DateInput id="date" />).dive(); | ||
| wrapper.setState({ dateString }); | ||
| wrapper.instance().componentWillReceiveProps({ displayValue: null }); | ||
| expect(wrapper.state().dateString).to.equal(dateString); |
There was a problem hiding this comment.
expect(wrapper.state()).to.have.property('dateString', dateString) has a better failure message
majapw
force-pushed
the
maja-uh-reopen-dateinput-issue
branch
from
0df2ba8
to
513bce6
Compare
ljharb
approved these changes
Jan 16, 2018
erin-doyle
reviewed
Jan 17, 2018
| @@ -121,8 +121,7 @@ class DateInput extends React.Component { | |||
| if (dateString[dateString.length - 1] === '?') { | |||
| onKeyDownQuestionMark(e); | |||
| } else { | |||
| this.setState({ dateString }); | |||
| onChange(dateString); | |||
| this.setState({ dateString }, () => onChange(dateString)); | |||
There was a problem hiding this comment.
Good call with this change 👍
erin-doyle
reviewed
Jan 17, 2018
test/components/DateInput_spec.jsx
Outdated
| @@ -89,6 +89,28 @@ describe('DateInput', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('#componentWillReceiveProps', () => { | |||
| describe('nextProps.displayValue exists', () => { | |||
| it('sets state.displayString to \'\'', () => { | |||
There was a problem hiding this comment.
Should this be state.dateString instead of state.displayString?
erin-doyle
reviewed
Jan 17, 2018
test/components/DateInput_spec.jsx
Outdated
| }); | ||
|
|
||
| describe('nextProps.displayValue does not exist', () => { | ||
| it('does not change state.displayString', () => { |
There was a problem hiding this comment.
Same here with dateString instead of displayString.
There was a problem hiding this comment.
You are right! Will fix
majapw
force-pushed
the
maja-uh-reopen-dateinput-issue
branch
from
513bce6
to
2f6f2cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github... did something very strange for me. :/
Fixes #805
Sorry @rokborf, I appear to have messed up the log on your original PR (#943)
What's weird is I literally just pushed the same code I had locally as I did to your branch... but github decided there were no changes. ANYWAYS @ljharb can you take a look and stamp?