Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all styles in the CCD (custom and default) to rely on custom styles #964

Merged
merged 1 commit into from
Jan 19, 2018

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Jan 19, 2018

As I have started using the CustomizableCalendarDay (again, not recommended but a very specific way of doing a very specific thing), I have found an issue where custom styles always override default styles. So, if you happen to have a day that is both blocked by minimum nights and selected (which happens all the time for a selected-start day with a minimum nights value greater than 0), if you have customized the minimum nights but not the selection, the minimum nights styling will always win.

We do not want this.

By moving the default stylings out of the StyleSheet and into props as default values, we address this issue.

to: @ljharb @erin-doyle @gabergg @noratarano @airbnb/webinfra

@majapw majapw added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Jan 19, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 86.65% when pulling 285033d on maja-move-default-CCD-styles-into-inline-styles into 2db60a8 on master.

@majapw majapw merged commit fea31aa into master Jan 19, 2018
@majapw majapw deleted the maja-move-default-CCD-styles-into-inline-styles branch January 19, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants