Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not apply verticalSpacing when withPortal or withFullScreenPortal is true #980

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Do not apply verticalSpacing when withPortal or withFullScreenPortal is true #980

merged 1 commit into from
Mar 9, 2018

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Jan 26, 2018

@coveralls
Copy link

coveralls commented Jan 26, 2018 •
edited

Coverage Status

Coverage increased (+0.02%) to 86.537% when pulling e07e494 on maja-fix-verticalSpacing-bug into 064b96c on master.

ljharb
ljharb approved these changes Jan 26, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@ljharb ljharb added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Jan 26, 2018
@majapw majapw force-pushed the maja-fix-verticalSpacing-bug branch from 821ed21 to e07e494 Compare March 9, 2018 20:31
@majapw majapw merged commit 2e10abf into master Mar 9, 2018
@majapw majapw deleted the maja-fix-verticalSpacing-bug branch March 9, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@majapw @coveralls @ljharb