Ensuring callbacks will execute after new state is ready. #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Jan 31, 2018
ljharb
added
the
semver-patch: fixes/refactors/etc
|
Not that i'm aware of. i think it's the minimal required fix for now :) |
|
@iliran11 can you make this change in the |
majapw
reviewed
Feb 1, 2018
| @@ -645,9 +645,10 @@ export default class DayPickerRangeController extends React.Component { | |||
| ...newVisibleDays, | |||
| ...this.getModifiers(nextMonthVisibleDays), | |||
| }, | |||
| }, () => { | |||
| onNextMonthClick(newCurrentMonth.clone()); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
I think we need to delete this blank line
|
@majapw - done! ;) |
|
Sweet, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onNextMonthClickandonPrevMonthClickcallbacks were seemingly executing right after updating the state ofDayPickerSingleDateController.jsx.However, It is not ensured and might cause some unexpected behavior caused by callbacks executing before the state update was completed (happened in my work project).
it is also a documented pitfall on react documentations.