The min-nights modifiers should get cleared according to the previous prop value not the new one

[majapw]

In addition, we don't seem to be removing the blocked modifier from these days at all. Whoops!

Here is a gif of the bug in action (not this only happens when you change the min nights value from a bigger value to a smaller value).

Now we will remove min nights blocking according to the previous value and also, any time the value changes (and reapply it for new >0 values).

to: @amhunt @ljharb @erin-doyle

[coveralls]

Coverage increased (+0.009%) to 84.832% when pulling 7b6b04b on maja-clear-min-nights-on-demand into 86cde2f on master.

[ljharb]

Without a regression test, I'm not really sure why this was broken nor why this fixes it; no objection to it tho.

[erin-doyle]

👍 on a little more detail and test(s).

[majapw]

I added some regression tests! Please take a look @ljharb

[ljharb]

fwiw, the linter will soon require:

const wrapper = shallow((
  <DayPickerRangeController
    startDate={startDate}
    focusedInput={focusedInput}
    minimumNights={minimumNights}
  />
));

[majapw]

we'll have to do a wholesale change of... most tests at that point. 😬

[amhunt]

Nice ! Looks good :)