New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Source Datadog: Make Builder Compatible #38148
Open
topefolorunso
wants to merge
6
commits into
master
Choose a base branch
from
tope/datadog-bldr-cmptbl
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
labels
May 12, 2024
girarda
requested changes
May 14, 2024
@@ -73,6 +73,7 @@ The Datadog source connector supports the following [sync modes](https://docs.ai | |||
|
|||
| Version | Date | Pull Request | Subject | | |||
| :------ | :--------- | :------------------------------------------------------- | :--------------------------------------------------------------------------- | | |||
| 0.4.1 | 2024-05-12 | [x](https://github.com/airbytehq/airbyte/pull/x) | Make Builder Compatible | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| 0.4.1 | 2024-05-12 | [x](https://github.com/airbytehq/airbyte/pull/x) | Make Builder Compatible | | |
| 0.4.1 | 2024-05-14 | [38148](https://github.com/airbytehq/airbyte/pull/38148) | Make Builder Compatible | |
path: "dashboard" | ||
|
||
downtimes_stream: | ||
$ref: "#/definitions/base_stream" | ||
name: "downtimes" | ||
primary_key: "id" | ||
$parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's completely delete the $parameters blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/datadog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Made Source Datadog compatible with the builder
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?