This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
Add workflow to check redirects for renamed files #1631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
angelinekwan
force-pushed
the
laysa-add-redirects-check
branch
from
5fae81c
to
9008b8d
Compare
Deploying with
|
| Latest commit: |
d3bf7a6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://67e7384d.devportal.pages.dev |
| Branch Preview URL: | https://laysa-add-redirects-check.devportal.pages.dev |
If a file is renamed, a redirect should be added. This script helps to check and report whether a renamed file is missing redirects. More info about the redirects process: https://docs.aiven.io/docs/community/documentation/tips-tricks/renaming-files.html
This checks in a pull request if a file was renamed without adding redirects. Shows the files, and info how to fix it.
laysauchoa
force-pushed
the
laysa-add-redirects-check
branch
from
9008b8d
to
d3bf7a6
Compare
|
Rebasing with main branch. |
|
Thanks for the contribution but we are moving away from the platform here, so we are not adding new features at this time. I am closing this out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file is renamed, a redirect should
be added. This workflow helps to check and
report whether a renamed file is missing
redirects.
The redirect process is done manually by the contributor, so we need to make sure during the review that we do not merge renamed files without proper redirects. This workflow helps with that.
Running time: ~14 seconds
More info about the redirects process:
https://docs.aiven.io/docs/community/documentation/tips-tricks/renaming-files.html
Fixes: #1602
How to test it? Fork the repo, bring those changes to your main and open pull requests changing name of the files with/without redirects, for example. For the individual functions, you can find some tests you can run yourself with pytest.