Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Look at CI and dependencies for AWS features #1671

Open
lornajane opened this issue Jan 4, 2023 · 0 comments
Open

Look at CI and dependencies for AWS features #1671

lornajane opened this issue Jan 4, 2023 · 0 comments
Assignees

Comments

@lornajane
Copy link
Contributor

We had a pull request that passed CI but then caused a build to fail when merged to main (#1668 - dependabot bumping the aws lib)

The build was only run on merge to main, not on pull request as most of the workflows are. This is because it also deploys the functions to AWS and we don't want to overwrite them on every build.

To solve the issue:

  • figure out a test deploy option so that we put the code through the motions and know that it CAN deploy even though it's not deploying to live, and so we can use that for pull requests that touch this area of the code
  • bump the library dependency as originally intended in the first PR!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants