CHANGELOG.md

@@ -2,6 +2,14 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [1.23.3](https://github.com/ajaxorg/ace/compare/v1.23.2...v1.23.3) (2023-07-10)
+
+
+### Bug Fixes
+
+* android bug when deleting multiple lines ([#5248](https://github.com/ajaxorg/ace/issues/5248)) ([bd066ff](https://github.com/ajaxorg/ace/commit/bd066ffef88ca74f5ac32349d3e868cfa875a47b)), closes [#5087](https://github.com/ajaxorg/ace/issues/5087)
+* update jshint version to 2.13.6; change esversion to target ECMAScript 11 ([#5243](https://github.com/ajaxorg/ace/issues/5243)) ([301aee9](https://github.com/ajaxorg/ace/commit/301aee91b5974d9fb31d646466ed301c5c3b8249))
+
 ### [1.23.2](https://github.com/ajaxorg/ace/compare/v1.23.1...v1.23.2) (2023-07-07)
 
 

lib/ace/mode/javascript/jshint.js

@@ -2392,13 +2392,13 @@ module.exports = slice;
     exports.noConflict = function () { global._ = current; return exports; };
   }()));
 }(this, (function () {
-  //     Underscore.js 1.13.4
+  //     Underscore.js 1.13.6
   //     https://underscorejs.org
   //     (c) 2009-2022 Jeremy Ashkenas, Julian Gonggrijp, and DocumentCloud and Investigative Reporters & Editors
   //     Underscore may be freely distributed under the MIT license.
 
   // Current version.
-  var VERSION = '1.13.4';
+  var VERSION = '1.13.6';
 
   // Establish the root object, `window` (`self`) in the browser, `global`
   // on the server, or `this` in some virtual machines. We use `self`
@@ -4461,7 +4461,7 @@ module.exports = slice;
 /*exported console */
 
 var _            = _dereq_("underscore");
-_.clone          = _dereq_("lodash.clone");
+_.clone = _dereq_("lodash.clone");
 var events       = _dereq_("events");
 var vars         = _dereq_("./vars.js");
 var messages     = _dereq_("./messages.js");
@@ -8930,7 +8930,7 @@ var JSHINT = (function() {
         var id = state.tokens.prev;
         value = expression(context, 10);
         if (value) {
-          if (value.identifier && value.value === "undefined") {
+          if (!isConst && value.identifier && value.value === "undefined") {
             warning("W080", id, id.value);
           }
           if (!lone) {
@@ -13527,7 +13527,7 @@ var errors = {
 
   // Constants
   E011: "'{a}' has already been declared.",
-  E012: "const '{a}' is initialized to 'undefined'.",
+  E012: "Missing initializer for constant '{a}'.",
   E013: "Attempting to override '{a}' which is a constant.",
 
   // Regular expressions
@@ -15122,7 +15122,7 @@ exports.regexpDot = /(^|[^\\])(\\\\)*\./;
  */
 
 var _      = _dereq_("underscore");
-_.slice    = _dereq_("lodash.slice");
+_.slice = _dereq_("lodash.slice");
 var events = _dereq_("events");
 
 // Used to denote membership in lookup tables (a primitive value such as `true`

lib/ace/mode/javascript_worker.js

@@ -79,7 +79,7 @@ oop.inherits(JavaScriptWorker, Mirror);
         this.options = options || {
             // undef: true,
             // unused: true,
-            esnext: true,
+            esversion: 11,
             moz: true,
             devel: true,
             browser: true,

package.json

@@ -1,7 +1,7 @@
 {
     "name": "ace-code",
     "description": "Ajax.org Code Editor is a full featured source code highlighting editor that powers the Cloud9 IDE",
-    "version": "1.23.2",
+    "version": "1.23.3",
     "homepage": "http://github.com/ajaxorg/ace",
     "engines": {
         "node": ">= 0.6.0"

src/config.js

@@ -168,6 +168,6 @@ var reportErrorIfPathIsNotConfigured = function() {
     }
 };
 
-exports.version = "1.23.2";
+exports.version = "1.23.3";
 
 

src/keyboard/textinput.js

@@ -83,8 +83,6 @@ var TextInput = function(parentNode, host) {
         if (ignoreFocusEvents) return;
         host.onBlur(e);
         isFocused = false;
-        if (isMobile && !isIOS)
-            document.removeEventListener("selectionchange", detectSelectionChange);
     }, host);
     event.addListener(text, "focus", function(e) {
         if (ignoreFocusEvents) return;
@@ -101,8 +99,6 @@ var TextInput = function(parentNode, host) {
             setTimeout(resetSelection);
         else
             resetSelection();
-        if (isMobile && !isIOS)
-            document.addEventListener("selectionchange", detectSelectionChange);
     }, host);
     this.$focusScroll = false;
     this.focus = function() {
@@ -291,25 +287,6 @@ var TextInput = function(parentNode, host) {
         }
     };
 
-    function detectSelectionChange(e) {
-        if (!text || !text.parentNode)
-            document.removeEventListener("selectionchange", detectSelectionChange);
-        if (inComposition) return;
-
-        if (text.selectionStart !== text.selectionEnd) return;
-        var startDiff = text.selectionStart - lastSelectionStart;
-        var oldLenght = lastSelectionEnd - lastSelectionStart;
-        if (startDiff > 0) {
-            startDiff = Math.max(startDiff - oldLenght, 1);
-        } else if (startDiff === 0 && oldLenght) {
-            startDiff = -1;
-        }
-        var repeat = Math.abs(startDiff);
-        var key = startDiff > 0 ? KEYS.right : KEYS.left;
-        for (var i = 0; i < repeat; i++) {
-            host.onCommandKey({}, 0, key);
-        }
-    }
 
     var inputHandler = null;
     this.setInputHandler = function(cb) {inputHandler = cb;};

src/keyboard/textinput_test.js

@@ -153,46 +153,6 @@ module.exports = {
         assert.equal(editor.getValue(), "y");
     },
 
-    "test: android spacebar moves cursor": function() {
-        setUserAgentForTests(true, false);
-        var value = "Juhu kinners!";
-        editor.setValue(value);
-        editor.blur();
-        editor.focus();
-        var lastCommand = "";
-        editor.commands.on("exec", function(e) {
-            lastCommand += e.command.name;
-        });
-
-        textarea.selectionStart = textarea.selectionEnd;
-        document.dispatchEvent(new CustomEvent("selectionchange"));
-        assert.equal(lastCommand, "gotoright");
-        lastCommand = "";
-
-        textarea.selectionStart = 
-        textarea.selectionEnd = textarea.selectionStart - 1;
-        document.dispatchEvent(new CustomEvent("selectionchange"));
-        assert.equal(lastCommand, "gotoleft");
-        lastCommand = "";
-
-        assert.equal(editor.getSelectedText(), "");
-        textarea.selectionStart = 0;
-        textarea.selectionEnd = textarea.value.length;
-        textarea.dispatchEvent(new CustomEvent("select"));
-        assert.equal(editor.getSelectedText(), value);
-
-        textarea.selectionEnd = textarea.selectionStart;
-        document.dispatchEvent(new CustomEvent("selectionchange"));
-        assert.equal(lastCommand, "gotoleft");
-        lastCommand = "";
-
-        textarea.selectionStart = 
-        textarea.selectionEnd = textarea.selectionEnd + 2;
-        document.dispatchEvent(new CustomEvent("selectionchange"));
-        assert.equal(lastCommand, "gotorightgotoright");
-        lastCommand = "";
-    },
-
     "test: composition with visible textarea": function() {
         var data = [
             // select ll

tool/tmtheme.js

@@ -4,11 +4,9 @@ var util = require("util");
 var cssParse = require("css-parse");
 var cssStringify = require("css-stringify");
 
-var parseString = require("plist").parseString;
+var parse = require("plist").parse;
 function parseTheme(themeXml, callback) {
-    parseString(themeXml, function(_, theme) {
-        callback(theme[0])
-    });
+    callback(parse(themeXml));
 }
 
 var unsupportedScopes = { };