Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special trigger characters to start autocomplete #5147

Merged
merged 3 commits into from May 12, 2023

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Apr 30, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mkslanc mkslanc changed the title Special trigger characters to start autocomplete [WIP] Special trigger characters to start autocomplete Apr 30, 2023
@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (204aafa) 86.94% compared to head (a4076e6) 86.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5147   +/-   ##
=======================================
  Coverage   86.94%   86.95%           
=======================================
  Files         561      561           
  Lines       44962    44990   +28     
  Branches     6913     6915    +2     
=======================================
+ Hits        39094    39122   +28     
  Misses       5868     5868           
Flag Coverage Δ
unittests 86.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/autocomplete/util.js 57.77% <100.00%> (+9.12%) ⬆️
src/autocomplete_test.js 99.41% <100.00%> (+0.07%) ⬆️
src/ext/language_tools.js 68.96% <100.00%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkslanc mkslanc changed the title [WIP] Special trigger characters to start autocomplete Special trigger characters to start autocomplete May 2, 2023
@mkslanc mkslanc marked this pull request as ready for review May 2, 2023 11:17
@oykuyilmaz oykuyilmaz merged commit c2cfc5a into ajaxorg:master May 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants