-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline autocomplete tooltip UX changes #5149
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5149 +/- ##
==========================================
+ Coverage 86.68% 86.92% +0.23%
==========================================
Files 560 561 +1
Lines 44223 44900 +677
Branches 6853 6907 +54
==========================================
+ Hits 38336 39028 +692
+ Misses 5887 5872 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Minor bugs:
|
5b2e65b
to
074b5f5
Compare
@skazantsev The things you mentioned are fixed in the last revision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one concern I have with the inline autocomplete is that the suggestions are not communicated to screen reader users afaict, but that's outside the scope of this PR.
Issue #, if available: N/A
Description of changes:
Changed UX of the inline tooltip for inline autocomplete.
Changes:
It can be tried out in the kitchen sink demo, by using the Alt-C|Option-C keybinding to trigger its appearance together with the inline autocompletion. By default, the kitchen sink demo initialises the tooltip in hover mode, so it will be only displayed if the mouse is over the active line. This setting can be changed in the toolbar's overflow menu.
Updated revision:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.