Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add support for Unicode boundaries #5265

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Jul 24, 2023

Issue #, if available: #5232

Description of changes:
Add support for Unicode boundaries and detection methods

  • Introduced Unicode boundaries support in text search
  • Added supportsLookbehind and supportsUnicodeFlag methods in lang for feature detection
  • Implemented fallback to ASCII boundaries when the browser does not support look-behinds
  • Implemented fallback to old behaviour (without unicode support) in rare edge cases for backward compatibility

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mkslanc mkslanc marked this pull request as ready for review July 27, 2023 12:21
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 95.55% and project coverage change: +0.01% 🎉

Comparison is base (31bbd6a) 87.23% compared to head (a775fcb) 87.24%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5265      +/-   ##
==========================================
+ Coverage   87.23%   87.24%   +0.01%     
==========================================
  Files         565      565              
  Lines       45248    45330      +82     
  Branches     6920     6934      +14     
==========================================
+ Hits        39470    39548      +78     
- Misses       5778     5782       +4     
Flag Coverage Δ
unittests 87.24% <95.55%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/lib/lang.js 73.33% <80.00%> (+0.60%) ⬆️
src/search.js 91.73% <100.00%> (+0.61%) ⬆️
src/search_test.js 99.63% <100.00%> (+0.02%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman merged commit 1e6fcf3 into ajaxorg:master Aug 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants