New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nasal language #5342
feat: add nasal language #5342
Conversation
Thank you for the contribution! The build has failed due to one of the regular expressions, could you please take a look? It would also be great if you could add a test for this newly added mode, there are examples of tests in https://github.com/ajaxorg/ace/tree/master/src/mode like https://github.com/ajaxorg/ace/blob/master/src/mode/javascript_test.js |
@InspiredGuy The regex should be fixed now. Do the tests need to be added now or can I add them in a later PR? |
@BobDotCom the build now fails due to linter errors, please take a look. We would prefer tests to be added to this PR, but your mode seems to just inherit the TextMode and not add any new behaviours so it should be fine as is. I would only ask to generate tokens for highlight rules test - see https://github.com/ajaxorg/ace/blob/master/src/mode/_test/Readme.md. |
@InspiredGuy I fixed those linter errors and generated the tokens, does that look good? |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5342 +/- ##
==========================================
+ Coverage 87.41% 87.47% +0.06%
==========================================
Files 574 579 +5
Lines 45613 45877 +264
Branches 6935 6954 +19
==========================================
+ Hits 39873 40133 +260
- Misses 5740 5744 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Looks good @BobDotCom , thank you |
Description of changes:
Adds syntax highlighting for the Nasal scripting language.
Nasal (Not Another Scripting LAnguage) is FlightGear's built-in scripting language.
https://wiki.flightgear.org/Nasal
http://plausible.org/nasal
https://github.com/BobDotCom/Nasal.tmbundle
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.