Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated red color in cloud-editor dark theme #5432

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

marinsokol5
Copy link
Contributor

Description of changes:

The new color meets the 4.5:1 contrast ratio, while the previous color didn't.

Screenshot 2023-12-19 at 14 15 23

Versus previous:

Screenshot 2023-12-19 at 14 16 08

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c216ef4) 87.59% compared to head (0812fa1) 87.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5432   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files         584      584           
  Lines       46408    46408           
  Branches     7021     7021           
=======================================
  Hits        40650    40650           
  Misses       5758     5758           
Flag Coverage Δ
unittests 87.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marinsokol5 marinsokol5 merged commit 142b607 into master Dec 19, 2023
3 checks passed
@marinsokol5 marinsokol5 deleted the theme-fix branch December 19, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants