Skip to content
This repository has been archived by the owner on Nov 21, 2020. It is now read-only.

Use default value for "Match highlight background color" instead of custom. #68

Open
DenysPanchenko opened this issue May 14, 2015 · 6 comments

Comments

@DenysPanchenko
Copy link

I use dark theme in Eclipse and customize some colors by myself. Regular eclipse consider my changes whereas Insta not.
instasearch_issue
OS: Windows 7, Eclipse Luna with MoonRise color theme

@ajermakovics
Copy link
Owner

Ah yes, looks like the color is hardcoded at the moment https://github.com/ajermakovics/eclipse-instasearch/blob/master/instasearch/src/it/unibz/instasearch/ui/ResultLabelProvider.java#L61
Would be better to get the one from Eclipse. There's probably API to get it somehow...

@omne777
Copy link

omne777 commented Jul 4, 2016

Hi,
may I ask if this issue is going to be fixed?

BR.

@asampal
Copy link

asampal commented Jun 25, 2017

I'm using the Darkest Dark theme with Eclipse Oxygen and, despite the PR referenced in #80 looking like it also fixes this issue, I'm still seeing unreadable match highlights. Looking over the code in that PR, it seems that there's a fallback to a hard-coded color (the one that I'm getting which makes the text impossible to read) if the one looked up (for search matches) isn't found. Since the looked-up color (ECLIPSE_SEARCH_UI_MATCH_HIGHLIGHT) isn't found, I'm wondering if this is the correct color to try and use here. As it is, it's not even clear to me which color I should try and modify to make things readable.

Can someone confirm that this is still broken with Eclipse Oxygen and dark themes?

@DanielJoyce
Copy link

Yeah. Still broken.

@ferradario
Copy link

Yup still broken, and very annoying.

@oliverlj
Copy link

oliverlj commented Aug 2, 2018

Solve in 1.5.7 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants