fix(options): fix losing parserOpts without preset #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to provide tests to prove that this is actually fixing something :) |
nmalaguti
force-pushed
the
feature/parserOpts-undefined
branch
2 times, most recently
from
5ec6486
to
53a18bc
Compare
`preset.parserOpts` may be undefined if no preset was specified in the options. `_.assign()` will return `undefined` if the first argument is `undefined`.
nmalaguti
force-pushed
the
feature/parserOpts-undefined
branch
from
53a18bc
to
8934e5b
Compare
|
Test written :). |
|
|
||
| it('should pass `parserOpts` to conventional-commits-parser', function(done) { | ||
| writeFileSync('test9', ''); | ||
| shell.exec('git add --all && git commit -m"test9" -m"Release note: super release!"'); |
|
Thanks. Merging. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preset.parserOptsmay be undefined if no preset was specified in theoptions.
_.assign()will returnundefinedif the first argument isundefined.