Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail to import context.json file #96

Closed
oupala opened this issue Aug 27, 2015 · 3 comments
Closed

fail to import context.json file #96

oupala opened this issue Aug 27, 2015 · 3 comments

Comments

@oupala
Copy link
Contributor

oupala commented Aug 27, 2015

A recent commit (feceb8b) tries to import required file at the correct directory.

It does work when importing a file with a relative path (as the relative path is built from the current path).

But it does not work when using an absolute path.

I call conventional-changelog from /home/user/dev/myproject/ and the json file is then at /home/user/dev/myproject/context.json.

Using the following command will work as context.json path will be built as /home/user/dev/myproject/ + context.json (I guess) which equals to /home/user/dev/myproject/context.json.

changelog [...] -c context.json

But the following command will not work as context.json path will be built as /home/user/dev/myproject/ + /home/user/dev/myproject/context.json (I guess) which equals to /home/user/dev/myproject/home/user/dev/myproject/context.json.

changelog [...] -c /home/user/dev/myproject/context.json

@stevemao
Copy link
Member

Fix welcome

@stevemao
Copy link
Member

Please include tests to prove it actually works. I also forgot to add some tests for feceb8b

@oupala
Copy link
Contributor Author

oupala commented Aug 28, 2015

I won't be the one who writes the fix, I'm really not skilled enough for that. Sorry.

I hope someone will take it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants