Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run test fails (async.spec.js) after clean clone and npm install #56

Open
timheilman opened this issue Dec 12, 2023 · 0 comments
Open

Comments

@timheilman
Copy link

timheilman commented Dec 12, 2023

To reproduce:

git clone git@github.com:ajv-validator/ajv-merge-patch.git
cd ajv-merge-patch
npm i
npm test

Expected: all tests pass
Actual:

  1) async schema loading
       $merge
         should load missing schemas:
     TypeError: resolver.resolve is not a function
      at resolveUrl (node_modules/ajv/dist/compile/resolve.js:90:21)
...
  2) async schema loading
       $patch
         should load missing schemas:
     TypeError: resolver.resolve is not a function
      at resolveUrl (node_modules/ajv/dist/compile/resolve.js:90:21)

This is due to a change introduced in ajv v8.10.0 which is pulled by the devDependency "ajv": "^8.2.0". Specifically,

ajv-validator/ajv@0e47ab4

This very short PR fixes this issue in the same technique as that commit in ajv.

timheilman added a commit to timheilman/ajv-merge-patch that referenced this issue Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant