-
-
Notifications
You must be signed in to change notification settings - Fork 895
Comparing changes
Open a pull request
base repository: ajv-validator/ajv
base: v8.1.0
head repository: ajv-validator/ajv
compare: v8.2.0
Commits on Apr 12, 2021
-
Add JTDDataType to compile signature
To get this to work, a few changes had to be made: 1. The semantics of `ref` for JTDDataType had to be changed. I don't entirely understand why, but my guess is that infer steps allow the compiler to "take a break" and so this helps with the recursion checking. 2. Added `SomeJTDSchemaType`. This is necessary to prevent typescript from inferring a JTDDataType when actually it's a different schema. This is especially a problem for simple types, e.g. the empty schema is valid JTD so it can confuse things. Three other notes about the current implementation. Historically specifying a type for compile indicated that that was the return type. To keep that working, the overload signatures for the JTDDataType returns need to have their first parameter extend never, so that it's only inferred (or it could be specified manually with `compile<never, ActualType>(...)`. In addition, SomeJTDSchemaType needs to use the empty type `{}`, there's a note linking to the issue that discusses how this is the one instance when this is actually what you want, and it's tested. Finally, this works with typescript 4.2.3. However, even with the infer trick, it's very close to the maximum complexity that typescript wants to deal with. Small changes in the overload signature or the way that typescript descides to handle this could result in compile erroring in typescript saying the type is too complex. In that event, this overload could always be removed, but I wanted to raise this potential risk now. fixes #1489
Configuration menu - View commit details
-
Copy full SHA for 59cdbdf - Browse repository at this point
Copy the full SHA 59cdbdfView commit details -
Update typescript getting started documentation
Raised this after discussion here: #1331 (comment)
Configuration menu - View commit details
-
Copy full SHA for 599fa28 - Browse repository at this point
Copy the full SHA 599fa28View commit details -
Merge pull request #1548 from alazyzombie/patch-1
docs: Update typescript getting started documentation
Configuration menu - View commit details
-
Copy full SHA for 8762e6f - Browse repository at this point
Copy the full SHA 8762e6fView commit details
Commits on Apr 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0d5c18c - Browse repository at this point
Copy the full SHA 0d5c18cView commit details
Commits on Apr 15, 2021
-
Merge pull request #1547 from erikbrinkman/jtd-type
Add JTDDataType to compile signature
Configuration menu - View commit details
-
Copy full SHA for baf1475 - Browse repository at this point
Copy the full SHA baf1475View commit details
Commits on Apr 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 364cc00 - Browse repository at this point
Copy the full SHA 364cc00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4470a8b - Browse repository at this point
Copy the full SHA 4470a8bView commit details
Commits on Apr 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b4e7749 - Browse repository at this point
Copy the full SHA b4e7749View commit details
Commits on Apr 23, 2021
-
Some improvements to JSONSchemaType for records
Additional properties doesn't required `type: "string"` since it's implied. `required` is no long required for objects without any required members. fixes #1491
Configuration menu - View commit details
-
Copy full SHA for d88ba06 - Browse repository at this point
Copy the full SHA d88ba06View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa6594f - Browse repository at this point
Copy the full SHA fa6594fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f45b963 - Browse repository at this point
Copy the full SHA f45b963View commit details
Commits on Apr 24, 2021
-
Merge pull request #1564 from erikbrinkman/jsonschematype-improvements
Some improvements to JSONSchemaType for records
Configuration menu - View commit details
-
Copy full SHA for 2edc54c - Browse repository at this point
Copy the full SHA 2edc54cView commit details -
Merge pull request #1561 from Delapouite/doc
doc: fix draft version typo (2012 → 2020)
Configuration menu - View commit details
-
Copy full SHA for 62e2992 - Browse repository at this point
Copy the full SHA 62e2992View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6497f14 - Browse repository at this point
Copy the full SHA 6497f14View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9e0676 - Browse repository at this point
Copy the full SHA c9e0676View commit details
Commits on Apr 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 55706db - Browse repository at this point
Copy the full SHA 55706dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e52716 - Browse repository at this point
Copy the full SHA 7e52716View commit details -
Configuration menu - View commit details
-
Copy full SHA for b780944 - Browse repository at this point
Copy the full SHA b780944View commit details
Commits on Apr 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b203181 - Browse repository at this point
Copy the full SHA b203181View commit details -
Configuration menu - View commit details
-
Copy full SHA for c672310 - Browse repository at this point
Copy the full SHA c672310View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff67954 - Browse repository at this point
Copy the full SHA ff67954View commit details -
Configuration menu - View commit details
-
Copy full SHA for e695db1 - Browse repository at this point
Copy the full SHA e695db1View commit details -
Merge pull request #1562 from ktrueda/fix/typescript_doc
doc: Fix JTD typescript sample error
Configuration menu - View commit details
-
Copy full SHA for d3bef59 - Browse repository at this point
Copy the full SHA d3bef59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30a8561 - Browse repository at this point
Copy the full SHA 30a8561View commit details -
Merge pull request #1533 from realityking/rollup-bundle
Rollup bundle
Configuration menu - View commit details
-
Copy full SHA for 00b0e24 - Browse repository at this point
Copy the full SHA 00b0e24View commit details
Commits on Apr 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for aa4f64f - Browse repository at this point
Copy the full SHA aa4f64fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ad97e8 - Browse repository at this point
Copy the full SHA 6ad97e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2123bf2 - Browse repository at this point
Copy the full SHA 2123bf2View commit details
There are no files selected for viewing
This file was deleted.