special case empty object for jtd #2158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
fixes #2123
What changes did you make?
In short, this special cases empty objects since they have special meaning due to the way typescripts type system works. I'll leave more detail in the issue.
Is there anything that requires more attention while reviewing?
I did some various "clean up" to JTD Schema as well, but the substantiative change is special casing that type and adding tests. I think the test coverage is pretty solid (although clearly not perfect) so I wouldn't be too worries.