Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix punycode deprecation warning #2377

Closed

Conversation

kibertoad
Copy link

fixes #2350 #2343

What issue does this pull request resolve?

punycode warnings. See linked issues.

What changes did you make?

Switched dependency to a fork that addresses the issue, and which is intended to be maintained for a long time.

Is there anything that requires more attention while reviewing?

No.

@kibertoad
Copy link
Author

@epoberezkin CI appears to be broken in this repo overall. Can I help with that?

@kibertoad
Copy link
Author

@jasoniangreen any chance you could take a look?

@jasoniangreen
Copy link
Collaborator

Hi @kibertoad sorry for the late reply. I have been speaking to @epoberezkin and he wants me to explore removing uri-js. It's not needed anymore for node given we are dropping older versions, but there is just an open question around browser support. I will update you when I have more.

@kibertoad
Copy link
Author

great news! thank you

@vixalien vixalien mentioned this pull request Apr 13, 2024
2 tasks
@tianyingchun
Copy link

#2415, also have this PR

@jasoniangreen
Copy link
Collaborator

I think if anything we'll go with #2415 or moving to a native approach so will close this.

@kibertoad
Copy link
Author

@jasoniangreen makes sense. what's preventing #2415 from being merged at this point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation Warning: punycode Dependency via uri-js
3 participants