From 2d5a28ade7266ba96dac189330b4c25f8a23cc9e Mon Sep 17 00:00:00 2001 From: aki-bot <103840025+aki-bot[bot]@users.noreply.github.com> Date: Tue, 26 Mar 2024 16:07:02 +0000 Subject: [PATCH 1/5] build(deps): update codecov/codecov-action action to v4 --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e4ea5eb..b411cd6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -37,6 +37,6 @@ jobs: - name: Upload test coverage to Codecov # yamllint disable-line rule:line-length - uses: codecov/codecov-action@ab904c41d6ece82784817410c45d8b8c02684457 # v3.1.6 + uses: codecov/codecov-action@c16abc29c95fcf9174b58eb7e1abf4c866893bc8 # v4.1.1 with: token: ${{ secrets.CODECOV_TOKEN }} From 109ad088c896b9e048e55247eebd45e2c68021b7 Mon Sep 17 00:00:00 2001 From: Aki Kanellis Date: Sat, 30 Mar 2024 23:41:55 +0200 Subject: [PATCH 2/5] fix: pass token for v4 --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b411cd6..ff8679a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -38,5 +38,5 @@ jobs: - name: Upload test coverage to Codecov # yamllint disable-line rule:line-length uses: codecov/codecov-action@c16abc29c95fcf9174b58eb7e1abf4c866893bc8 # v4.1.1 - with: - token: ${{ secrets.CODECOV_TOKEN }} + env: + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} From a2595668187cabd6038e513fbdb53c6820ba2019 Mon Sep 17 00:00:00 2001 From: Aki Kanellis Date: Sun, 31 Mar 2024 20:20:25 +0300 Subject: [PATCH 3/5] fix: pass in Codecov token from caller workflows --- .github/workflows/build-main.yml | 2 ++ .github/workflows/build-pr.yml | 2 ++ .github/workflows/test.yml | 4 ++++ 3 files changed, 8 insertions(+) diff --git a/.github/workflows/build-main.yml b/.github/workflows/build-main.yml index befe244..4309bf7 100644 --- a/.github/workflows/build-main.yml +++ b/.github/workflows/build-main.yml @@ -30,6 +30,8 @@ jobs: uses: ./.github/workflows/test.yml with: continue-on-error: true + secrets: + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} release: name: Release diff --git a/.github/workflows/build-pr.yml b/.github/workflows/build-pr.yml index 33f63da..442c630 100644 --- a/.github/workflows/build-pr.yml +++ b/.github/workflows/build-pr.yml @@ -17,6 +17,8 @@ jobs: test: name: Test uses: ./.github/workflows/test.yml + secrets: + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} validate-branch-name: name: Validate branch name diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ff8679a..b0c8f67 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -9,6 +9,10 @@ name: Test description: Allow a workflow run to pass when this workflow fails required: false default: false + secrets: + CODECOV_TOKEN: + description: The token used by Codecov + required: true jobs: test: From 00ce054687fd038c1600f53b5293624a16f569bf Mon Sep 17 00:00:00 2001 From: Aki Kanellis Date: Sun, 31 Mar 2024 20:31:09 +0300 Subject: [PATCH 4/5] build: pass token in `with` --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b0c8f67..31fe555 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -42,5 +42,5 @@ jobs: - name: Upload test coverage to Codecov # yamllint disable-line rule:line-length uses: codecov/codecov-action@c16abc29c95fcf9174b58eb7e1abf4c866893bc8 # v4.1.1 - env: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + with: + token: ${{ secrets.CODECOV_TOKEN }} From 76166e4f3eecdbbfcfa988cc05234975866ea5b6 Mon Sep 17 00:00:00 2001 From: Aki Kanellis Date: Sun, 31 Mar 2024 20:34:00 +0300 Subject: [PATCH 5/5] build: fail CI if coverage upload fails --- .github/workflows/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 31fe555..b964a98 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -44,3 +44,4 @@ jobs: uses: codecov/codecov-action@c16abc29c95fcf9174b58eb7e1abf4c866893bc8 # v4.1.1 with: token: ${{ secrets.CODECOV_TOKEN }} + fail_ci_if_error: true