Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide SelectEffect when editing the CanvasItem model properties #244

Open
Alecaddd opened this issue Jan 7, 2020 · 1 comment
Open

Hide SelectEffect when editing the CanvasItem model properties #244

Alecaddd opened this issue Jan 7, 2020 · 1 comment

Comments

@Alecaddd
Copy link
Member

Alecaddd commented Jan 7, 2020

Expected Behavior

When the user edits the properties of a CanvasItem the SelectEffect should disappear until the end of the interaction, with a delay of 2 seconds.

This behaviour is commonly used in other design tools to remove the visual noise of the selection bound when the user needs to edit the visual aspects of an item.

Eg. editing the color of a 1px thick border is pretty hard with the selection bound border in the way.

Current Behavior

The selection effect is always visible.

Possible Solution

We should emit a signal whenever a property we know can benefit from not having the selection visible is getting edited by the user.
The SelectedBoundManager can then hide itself and set a delay of 2 seconds before turning back visible.

I'm suggesting the use of a delay to avoid visual glitches when quickly editing a property. eg. typing the color or the opacity value.

@Alecaddd Alecaddd added this to To do in Canvas Library via automation Jan 7, 2020
@Alecaddd Alecaddd added this to the v1.0 milestone Jan 7, 2020
@Alecaddd
Copy link
Member Author

Alecaddd commented Jan 8, 2020

This will also help us to solve the problem of updating the selection bounds when the border thickness changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Canvas Library
  
To do
Development

No branches or pull requests

1 participant