Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce kafka docker version constraint #1493

Closed
wants to merge 5 commits into from
Closed

Reduce kafka docker version constraint #1493

wants to merge 5 commits into from

Conversation

yuvalshi0
Copy link
Contributor

@yuvalshi0 yuvalshi0 commented Apr 9, 2022 •
edited

Closes #1424

I don't know if this is the best solution, but since some people might want to use a custom tag (like building a cp-kafka image on M1), a good idea might be to just use the 5.2.0 and above connect param, tested at:

alpakka-kafka/testkit/src/main/java/akka/kafka/testkit/internal/KafkaContainerCluster.java

Line 310 in 9419b5d

if (this.kafkaImageTag.compareTo(BOOTSTRAP_PARAM_MIN_VERSION) >= 0) {

So, if the tag is not "comparable", we will just use the newer connect param

@yuvalshi0 yuvalshi0 marked this pull request as draft April 9, 2022 13:19
@yuvalshi0 yuvalshi0 marked this pull request as ready for review April 9, 2022 13:19
@yuvalshi0 yuvalshi0 marked this pull request as draft April 9, 2022 14:05
@yuvalshi0 yuvalshi0 marked this pull request as ready for review April 9, 2022 14:37
@ennru
Copy link
Member

ennru commented May 1, 2022

Wouldn't it be much better to allow setting the value to be returned from kafkaTopicConnectParam?

@yuvalshi0
Copy link
Contributor Author

Wouldn't it be much better to allow setting the value to be returned from kafkaTopicConnectParam?

And saving the version as a simple string? Couldn't it break backward compatibility?

@ennru
Copy link
Member

ennru commented May 28, 2022

Ok, I finally looked a bit into what you are trying to solve here. Your problem boils down which flags to pass on the command lines for zookeeper or non-zookeeper.
My suggestion is to move the comparison into the Version class as usesZookeeper and add some logic that works for the version schemes you notice with Redpanda and others.

@patriknw
Copy link
Member

@yuvalshi0 What do you think about @ennru 's suggestion, and would you be able to continue on this PR?

@yuvalshi0
Copy link
Contributor Author

Ok, I finally looked a bit into what you are trying to solve here. Your problem boils down which flags to pass on the command lines for zookeeper or non-zookeeper. My suggestion is to move the comparison into the Version class as usesZookeeper and add some logic that works for the version schemes you notice with Redpanda and others.

I personally don't use red panda, rather I build a completely custom tags (mainly because there are no official arm docker images for Kafka), how do you think we should handle a tag which does not follow any schema?

@yuvalshi0
Copy link
Contributor Author

@yuvalshi0 What do you think about @ennru 's suggestion, and would you be able to continue on this PR?

Missed that PR because Gmail moved it to my spam 😅, will do now

@yuvalshi0 yuvalshi0 closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
testkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce kafka docker version constraint
3 participants
@yuvalshi0 @ennru @patriknw