Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Configurable HTTP Client #209

Open
dennym opened this issue Jul 31, 2023 · 0 comments
Open

[FEATURE] Configurable HTTP Client #209

dennym opened this issue Jul 31, 2023 · 0 comments
Assignees

Comments

@dennym
Copy link

dennym commented Jul 31, 2023

Is your feature request related to a problem? Please describe.
Currently prom_ex is "completely hardcoded" with finch. This makes it impossible to use some other client, e.g. Tesla, hackney, etc
Settings for finch have to be passed through grafana: finch_pools: [] and will be duplicate. Even if there is already an application in the Supervisor I can not pass in MyApp.Finch.

Describe the solution you would like to see
Make http client configurable.

How would you expect this feature to work
config :prom_ex, :http_client, MyApp.HTTPClient

Additional context
Swoosh has some approach to it...
https://github.com/swoosh/swoosh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants