Flow control stage not showing Freight ID

[tal-hason]

When creating a flow control stage, that just subscribes to the upstream stages, when this stage gets promoted in the UI no freight ID is shown:

apiVersion: kargo.akuity.io/v1alpha1
kind: Stage
metadata:
  name: prod-ready
  namespace: gotham-kargo
  annotations:
    kargo.akuity.io/color: fuchsia
spec:
  subscriptions:
    upstreamStages:
    - name: code-testing
    - name: security-testing

in the UI it Looks like that:

you can see that the stage doesn't have a freight id and the image on the right side does not update the color for the current stage.

this is very confusing

[krancour]

Hey @tal-hason, I can clear up some of the confusion, but there is also some behavior here that needs fixing.

"Control flow" Stages have no promotion mechanisms and aren't backed by an environment, and with this being the case, they never undergo any state changes. So it's not only that the UI isn't showing the control flow Stage's current Freight. The control flow Stage doesn't have any current Freight.

With this being the case, the effect of the following buttons seems rather ambiguous:

• The buttons for pushing from code-testing and code-security to prod-ready
• The button for pulling to prod-ready from either of code-testing or code-security
• The button for pushing from prod-ready to prod-east and prod-west
• The buttons for pulling to prod-east or prod-west from prod-ready

Probably this isn't just a UI fix. The most sensible thing may be to just start permitting control flow Stages to reference a current Freight even though no real state change will occur. Then most, if not all, of the confusion above goes away.

[krancour]

I opened #982 to track this.