Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Configuration in Helm chart #1813

Closed
3 tasks done
danielloader opened this issue Apr 10, 2024 · 1 comment · Fixed by #1904
Closed
3 tasks done

Global Configuration in Helm chart #1813

danielloader opened this issue Apr 10, 2024 · 1 comment · Fixed by #1904

Comments

@danielloader
Copy link

Checklist

  • I've searched the issue queue to verify this is not a duplicate feature request.
  • I've pasted the output of kargo version, if applicable.
  • I've pasted logs, if applicable.

Proposed Feature

A global configuration block akin to the argocd one: https://github.com/argoproj/argo-helm/blob/f42e0e1fd586d48459d99db69e65f2540a5cd209/charts/argo-cd/values.yaml#L38-L149

Motivation

This is quite... a lot to set to have a global toleration on a node group.

api:
  tolerations: 
    - key: "CriticalAddonsOnly"
      operator: "Exists"
  oidc:
    dex:
      tolerations: 
        - key: "CriticalAddonsOnly"
          operator: "Exists"
controller:
  tolerations: 
    - key: "CriticalAddonsOnly"
      operator: "Exists"
managementController:
  tolerations: 
    - key: "CriticalAddonsOnly"
      operator: "Exists"
webhooksServer:
  tolerations: 
    - key: "CriticalAddonsOnly"
      operator: "Exists"
garbageCollector:
  tolerations: 
    - key: "CriticalAddonsOnly"
      operator: "Exists"

Suggested Implementation

Follow the ArgoCD chart and have some things that can be globally set on all pods.

@danielloader
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants