Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): allow config of global defaults #1904

Merged
merged 1 commit into from
May 21, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Apr 29, 2024

Fixes: #1813

This moves the .additionalLabels configuration to .global.additionalLabels in a backward-compatible manner.

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 739c7d1
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/662fb6adad4b340008ac4e44
😎 Deploy Preview https://deploy-preview-1904.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.74%. Comparing base (14522e0) to head (739c7d1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1904   +/-   ##
=======================================
  Coverage   46.74%   46.74%           
=======================================
  Files         220      220           
  Lines       14411    14411           
=======================================
  Hits         6737     6737           
  Misses       7374     7374           
  Partials      300      300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco changed the title feat(chart): allow config if global defaults feat(chart): allow config of global defaults Apr 29, 2024
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco marked this pull request as ready for review April 29, 2024 15:22
@hiddeco hiddeco requested a review from a team as a code owner April 29, 2024 15:22
@krancour krancour added this to the v0.7.0 milestone Apr 29, 2024
@hiddeco hiddeco added this pull request to the merge queue May 21, 2024
Merged via the queue into akuity:main with commit 4610617 May 21, 2024
17 checks passed
@hiddeco hiddeco deleted the global-chart-values branch May 21, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Configuration in Helm chart
2 participants