Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PromotionInfo contains duplicate information about the involved Freight #1929

Open
hiddeco opened this issue May 2, 2024 · 0 comments
Open

Comments

@hiddeco
Copy link
Contributor

hiddeco commented May 2, 2024

Due to #1748 adding the Status of the Promotion to the PromotionInfo, and #1721 adding the Freight itself. The PromotionInfo now contains a duplicate FreightReference, as the Status of the Promotion does also include it.

  lastPromotion:
    name: ab-test-a.01hww6gj8ez5zxvgat11g5rtrt.cb03f5a
    freight:
      # ...omitted for brevity
    status:
      phase: Succeeded
      freight:
        name: cb03f5ab8aa44d64fa8680e0ff35cb47d27e9fe6
       # ...omitted for brevity

This should be addressed, possibly by removing the Status in favor of copying specific fields of interest to present in the frontend (cc: @rbreeze).

@hiddeco hiddeco added this to the v0.7.0 milestone May 2, 2024
@krancour krancour removed this from the v0.7.0 milestone May 2, 2024
@hiddeco hiddeco self-assigned this May 17, 2024
@hiddeco hiddeco added this to the v0.7.0 milestone May 17, 2024
@krancour krancour removed this from the v0.7.0 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants