Promotions should be sorted lexicographically

[hiddeco]

The UI API server appears to order Promotions for a Stage by their Phase and creation timestamp. However, as the creation timestamp does not include nanoseconds, this approach will fail when multiple Promotions are (programmatically) created within a short period.

To address this issue, it should use the ULID in the Promotion name, which allows it to be lexicographically sorted beyond the creation timestamp of the Promotion.

[webstradev]

Is this done by parsing the promotion name "shortName.ulid.shorthash" (maybe making a helper function on the Promotion struct for that) and sorting on that instead of the creation time?

[hiddeco]

It would not require parsing, the ULID component in the name would make any list entry sortable by default.

[hiddeco]

To clarify: as far as I am aware this is a frontend issue which would not require any changes to the backend.

[hiddeco]

See also:

kargo/ui/src/features/stage/utils/sort.ts

Line 3 in 769d1fc

export const sortPromotions = (a: Promotion, b: Promotion) => {

[webstradev]

It would not require parsing, the ULID component in the name would make any list entry sortable by default.

Ah I see I didn't realize we are always dealing with the same prefix (stage name) so we can indeed just sort on the Name.

Are you sure we should be sorting this in the frontend and not in the api though.

I know the frontend is also sorting it, but shouldn't we aim to sort it in the backend in general is more the quest

[webstradev]

Maybe doing so doesn't solve the issue you originally raised, as you still have some more "advanced" sorting in the frontend with running promotions versus non running. But it would I believe still make sense to change this in the API as well, to ensure we are returning properly sorted results there as well.

[krancour]

Agree it's ideally a back end change. Re-labeling accordingly.

[webstradev]

Ill work on this.

[krancour]

Thank you!