Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing static row classes #1326

Open
nikita-fuchs opened this issue Sep 6, 2022 · 0 comments
Open

Allow providing static row classes #1326

nikita-fuchs opened this issue Sep 6, 2022 · 0 comments

Comments

@nikita-fuchs
Copy link

nikita-fuchs commented Sep 6, 2022

Currently, the only way to provide a class to rows seems to be via a function:

 this.settings = {
      rowClassFunction: (row) => {console.log('And again', row); return 'address-column-entry'; },
...

this was introduced in this PR: #355

The issue with this pattern is that angular re-executes all functions bound to a template ( see className input here ) during change detection. Depending on how many rows the table has, this leads to unnecessary / heavy performance issues, as the classes are recalculated and applied to the DOM continuously. This is explained here very well: https://lukeliutingchun.medium.com/angular-performance-issue-caused-by-function-calls-in-template-a1a930f40464

With my example code, you can see the function being re-executed endlessly in the console.

It would be nice to have a way to statically set classes to rows, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant