Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autofix/sort-imports doesn't autofix #49

Open
dkent600 opened this issue Jul 17, 2019 · 6 comments
Open

autofix/sort-imports doesn't autofix #49

dkent600 opened this issue Jul 17, 2019 · 6 comments

Comments

@dkent600
Copy link

dkent600 commented Jul 17, 2019

autofix/sort-imports reports error but doesn't autofix.

the rule:

"autofix/sort-imports": ["error", {
          "ignoreCase": true,
          "ignoreMemberSort": false,
          "memberSyntaxSortOrder": ["none", "all", "single", "multiple"]
        }]

the imports:

import { DAO, IProposalCreateOptions, IProposalOutcome, ITransactionState, ITransactionUpdate } from "@daostack/client";
import { IAsyncAction } from "actions/async";
import { getArc } from "arc";
import { toWei } from "lib/util";
import { IRedemptionState } from "reducers/arcReducer";
import { IRootState } from "reducers/index";
import { NotificationStatus, showNotification } from "reducers/notifications";
import { Dispatch } from "redux";
import * as Redux from "redux";
import { ThunkAction } from "redux-thunk";

This is a .tsx file, where the AST is being generated by https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser

.eslintrc is attached

.eslintrc.zip

@g-plane
Copy link
Collaborator

g-plane commented Jul 17, 2019

Hi @dkent600 , you can consider eslint-plugin-import.

@dkent600
Copy link
Author

I could, but isn't this what eslint-plugin-autofix claims to do?

@dkent600
Copy link
Author

@g-plane eslint-plugin-import works, thanks for the suggestion

@g-plane g-plane closed this as completed Jul 18, 2019
@Nantris
Copy link

Nantris commented May 27, 2021

Why is this rule included in "autofix" if it's not fixed? Pretty frustrating.

@aladdin-add
Copy link
Owner

IMO, it should be fixed.

@aladdin-add aladdin-add reopened this May 29, 2021
@alekcastillo
Copy link

False advertising lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants