Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin-autofix bug - documentation update #63

Closed
stephen-dirtcreative opened this issue Mar 7, 2020 · 1 comment
Closed

eslint-plugin-autofix bug - documentation update #63

stephen-dirtcreative opened this issue Mar 7, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@stephen-dirtcreative
Copy link

Tell us about your environment

  • eslint version:
    6.8.0

  • eslint-plugin-autofix version:
    1.0.0

  • eslint config:
    relevant snip:
    {...rules: [
    ...
    'autofix/no-unsafe-negation': 'error',
    ...
    ]}
    Expected behavior
    Rule defined

Actual behavior
Linter error for each file:
error Definition for rule 'autofix/no-unsafe-negation' was not found autofix/no-unsafe-negation

Triage performed:
If I understand the plugin code, it has a small set of custom rules it supplies, and then also defines all base eslint rules that have meta property 'fixable' that is true. Currently, eslint sets 'fixable' to null for 'no-unsafe-negation', and there is no custom rule in the autofix plugin. As a result, I would recommend removing 'no-unsafe-negation' from the documentation/README as a supported rule in autofix, or if it does work with specific versions of ESLint, add a note about that.

I don't use every supported rule autofix claims to support, but of the number of them I have configured, this is the only one that has this problem.

Thanks!

@stephen-dirtcreative stephen-dirtcreative added the bug Something isn't working label Mar 7, 2020
@aladdin-add
Copy link
Owner

emm... the fixer was removed in eslint v6.4.0 (eslint/eslint#12157), and I forgot to update the readme somehow.

will update later, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants